Draft
Conversation
Stringy
approved these changes
Oct 31, 2025
Contributor
Stringy
left a comment
There was a problem hiding this comment.
Looks good! how would this look in the protos?
Contributor
Author
|
I guess we could do something like this: message FileMetadata {
uint32 mode;
uint32 uid;
uint32 gid;
int64 size;
}
message FileActivity {
google.protobuf.Timestamp timestamp = 1;
ProcessSignal process = 2;
oneof file {
FileCreation creation = 3;
FileUnlink unlink = 4;
FileRename rename = 5;
FilePermissionChange permission = 6;
FileOwnershipChange ownership = 7;
FileOpen open = 8;
FileWrite write = 9;
}
FileMetadata metadata = 10;
}We would need to make it clear the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is currently a PoC for adding file metadata to our events.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.