Merged
Conversation
xen2
approved these changes
Feb 26, 2026
Jklawreszuk
approved these changes
Feb 26, 2026
Contributor
Author
|
Can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
When building Stride, thousands of warnings are generated. This pull request addresses many of the ones unrelated to nullability. Notably:
typeofparameter were replaced with their generic overload, if available.Readwere replaced withReadExactly.SymbolEqualityComparer.Defaultis now used to compare assemblies.PendingPackageUpgrade::GetHashCodeto align behavior withEquals.Related Issue
The use of generic overloads will help with trimming and NativeAOT (#2069).
Types of changes
Checklist