Skip to content

fix: Many Stride build warnings#3076

Merged
xen2 merged 2 commits intostride3d:masterfrom
ds5678:fix-warnings
Mar 8, 2026
Merged

fix: Many Stride build warnings#3076
xen2 merged 2 commits intostride3d:masterfrom
ds5678:fix-warnings

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Feb 26, 2026

PR Details

When building Stride, thousands of warnings are generated. This pull request addresses many of the ones unrelated to nullability. Notably:

  • Method calls taking a typeof parameter were replaced with their generic overload, if available.
  • Calls to Read were replaced with ReadExactly.
  • Some synchronous calls were replaced with asynchronous alternatives.
  • General xUnit assert calls were replaced with more specific ones.
  • Two static constructors were removed since they only initialized fields.
  • SymbolEqualityComparer.Default is now used to compare assemblies.
  • I implemented PendingPackageUpgrade::GetHashCode to align behavior with Equals.

Related Issue

The use of generic overloads will help with trimming and NativeAOT (#2069).

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@ds5678
Copy link
Contributor Author

ds5678 commented Mar 4, 2026

Can this be merged?

@xen2 xen2 merged commit 211c987 into stride3d:master Mar 8, 2026
9 checks passed
@ds5678 ds5678 deleted the fix-warnings branch March 8, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants