Spawn children in their own process groups, and deliver SIGINT to each group#177
Open
benweint wants to merge 2 commits intostrongloop:masterfrom
Open
Spawn children in their own process groups, and deliver SIGINT to each group#177benweint wants to merge 2 commits intostrongloop:masterfrom
benweint wants to merge 2 commits intostrongloop:masterfrom
Conversation
) Signed-off-by: Ben Weintraub <[email protected]>
Signed-off-by: Ben Weintraub <[email protected]>
|
@benweint Would you be willing to push up a your fork to npm, appropriately renamed? This is an important project! StrongLoop is totally dead, and their most popular tech (Loopback) appears to live on (after being acquired?) as a distinct organization. I don't think there is any hope of this repo getting any more attention... :( |
|
Perhaps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the issue described in #176 by:
nfspawn each child process in its own distinct process group via thedetachedoptionSIGINTsignals to children to the entire process group, rather than just the direct childnfcan handle the delivery of multiple consecutiveSIGINTsignals to itself without exiting prematurelyChanges 1 & 2 are inspired by the approach taken by goreman (a similar tool implemented in Go). Change 3 is somewhat unrelated, but was added in order to deal with the problem described in pnpm/pnpm#7374 (sometimes, a parent process of
nfmight itself forward aSIGINTtonf, and the terminal might also deliver that signal).