BridgeJS: Import-side Array Support #573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hey @kateinoigakukun, this is a PR where I tried implementing import-side array support for BridgeJS. I noticed your PR #572 covers the same area, so I integrated some of the fixes from there (like
stackLoweringStmts,Array: _BridgedSwiftStackTypeconformance, thelet _ =pattern, and the liftReturn fix for 0-param fragments).Hopefully some parts of this can help you finalise your PR. Feel free to close if not needed.
Additional bits not in #572
checker.isArrayType()sonumber[]generates[Double]instead ofJSObjectbridge-js.d.tsdeclarations, Swift test cases, and JS implementations for:jsRoundTripNumberArray/jsRoundTripStringArray/jsRoundTripBoolArrayjsSumNumberArray/jsCreateNumberArray