Skip to content

fix: claude workflows + remove updater#816

Merged
ovitrif merged 5 commits intomasterfrom
fix/claude-review
Mar 3, 2026
Merged

fix: claude workflows + remove updater#816
ovitrif merged 5 commits intomasterfrom
fix/claude-review

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Mar 2, 2026

Summary

  • Fix Claude code review workflow
    • Removed claude_args and allowed_bots — the --allowed-tools Bash(gh:*) WebFetch restriction prevented Claude from using essential tools (Read, Grep, Glob, Agent) needed to analyze code, causing expensive runs ($9+) that posted zero review comments
    • Removed deprecated use_api_for_commits from claude.yml
    • Added concurrency block to prevent duplicate review runs when a PR is updated in quick succession
    • Added reference comment links to working configurations (bitkit-ios, ldk-node)
  • Remove updater release tooling (now in synonymdev/bitkit monorepo)
    • Deleted .github/release.json — now lives at updater/android/release.json in the bitkit monorepo
    • Removed updater-related steps (--critical arg, release.json editing) from /release slash command
  • Bump ldk-node-android from 0.7.0-rc.29 to 0.7.0-rc.31

Test plan

🤖 Generated with Claude Code

@ovitrif ovitrif marked this pull request as draft March 2, 2026 12:07
@ovitrif ovitrif changed the title fix: remove claude_args restriction from code review fix: claude code review workflow Mar 2, 2026
@ovitrif ovitrif marked this pull request as ready for review March 2, 2026 19:30
ovitrif and others added 3 commits March 2, 2026 21:01
The claude_args '--allowed-tools Bash(gh:*) WebFetch' prevented
Claude from using essential tools (Read, Grep, Glob, Agent) needed
to actually analyze code. This caused $9+ runs with zero review
comments. Remove claude_args and allowed_bots to match the working
bitkit-ios configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- claude-code-review.yml: remove allowed_bots and claude_args, add
  reference comment links
- claude.yml: remove deprecated use_api_for_commits

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a PR is updated in quick succession, multiple review runs would
stack up. The concurrency group cancels in-progress runs for the same PR.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif ovitrif force-pushed the fix/claude-review branch from 7544b7c to aafd454 Compare March 2, 2026 20:01
@ovitrif

This comment was marked as outdated.

@ovitrif ovitrif enabled auto-merge March 2, 2026 20:09
@ovitrif ovitrif requested review from jvsena42 and pwltr March 2, 2026 21:02
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif ovitrif changed the title fix: claude code review workflow fix: clean up claude workflows and remove updater tooling Mar 2, 2026
@ovitrif ovitrif changed the title fix: clean up claude workflows and remove updater tooling fix: clean up claude workflows and remove updater Mar 2, 2026
@ovitrif ovitrif changed the title fix: clean up claude workflows and remove updater fix: claude workflows + remove updater Mar 2, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif ovitrif merged commit 3801801 into master Mar 3, 2026
13 of 14 checks passed
@ovitrif ovitrif deleted the fix/claude-review branch March 3, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants