Fix: Show savings activity list when balance is zero but activities exist#469
Merged
Fix: Show savings activity list when balance is zero but activities exist#469
Conversation
…ro but activities exist When savings (or spending) balance was 0, tapping the wallet card showed the empty state "SEND BITCOIN TO YOUR SAVING BALANCE" screen instead of the activity list. This happened because the activity list visibility was gated solely on balance > 0. Now the activity list is shown when there's either a positive balance OR existing activities. The empty state is only shown when both balance is zero AND there are no activities. The transfer button remains gated behind a positive balance since there's nothing to transfer when balance is zero. Fixes #464
Collaborator
|
IIRC the issue fixed here repros in Android as well 😢 |
Contributor
Author
|
@ovitrif on android it seems correct already actually. |
pwltr
approved these changes
Mar 3, 2026
jvsena42
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #464 — When savings balance is
0, tapping the savings card showed the generic "SEND BITCOIN TO YOUR SAVING BALANCE" empty state screen instead of the savings activity list.Root Cause
In
SavingsWalletView, the activity list (ScrollView with ActivityList) was only rendered whenwallet.totalOnchainSats > 0. When balance reached zero (e.g., after transferring all funds to spending), the view fell through to theEmptyStateViewoverlay, hiding all transaction history.Changes
SavingsWalletView.swift: Show activity list when balance > 0 OR when there are onchain activities. Only show empty state when both balance is zero AND no activities exist. Transfer button remains gated behind positive balance.SpendingWalletView.swift: Applied the same fix for consistency — show activity list when balance > 0 OR when there are lightning activities.Testing