Implement an explicit ordering for layers#42
Open
gravitystorm wants to merge 1 commit intosystemed:masterfrom
Open
Implement an explicit ordering for layers#42gravitystorm wants to merge 1 commit intosystemed:masterfrom
gravitystorm wants to merge 1 commit intosystemed:masterfrom
Conversation
44024e6 to
729e7f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my approach for resolving #33 .
I considered the alternative approaches discussed in that issue, like adding an integer "sort order" to each layer, but I felt that was hard to manage. I've gone for the approach that I discussed of having an explicit central layer order. This is also how cartocss works, so it's not a novel approach.
This PR adds an optional "layer_order" method. If this is omitted, then layers are outputted in the order they are defined. If the
layer_orderis defined, then it used instead of the natural sort order, and any layers not mentioned are not found in the output.There is also some handling of automatically generated sub-layers. If only the parent layer is mentioned, then that layer and all of the sublayers are outputted. If a sublayer is mentioned, then all sublayers are treated independently and must be explicitly mentioned.
I'm using this code in production with my Transport style.