Skip to content

fix(view): add props for width and height to x-icon#1969

Merged
brendt merged 3 commits intotempestphp:3.xfrom
iamdadmin:3.x-x-icon-default-sizing
Mar 10, 2026
Merged

fix(view): add props for width and height to x-icon#1969
brendt merged 3 commits intotempestphp:3.xfrom
iamdadmin:3.x-x-icon-default-sizing

Conversation

@iamdadmin
Copy link
Contributor

Closes #1955

  • Add props for width and height to x-icon, and ability to disable it entirely so it can be set in style or class

  • Add prop for style

  • Update docs

  • Update tests

@iamdadmin
Copy link
Contributor Author

Weird, I thought that checks were set for manual trigger, I know they are going to fail as it stands as the tests aren't finished, hence leaving it in draft. Sorry, had I known they'd run I wouldn't have raised it as a draft until I had clean tests!

@iamdadmin iamdadmin changed the title fix(view): add props for width and height to x-icon fix(view): add props for width and height to x-icon Feb 13, 2026
@iamdadmin
Copy link
Contributor Author

Ready for review, I'd suggest squashing this commit as prettier which wasn't supposed to run on markdown files, ran on markdown files and really messed up the formatting, so there's some regression commits that are over the top.

@iamdadmin iamdadmin marked this pull request as ready for review February 13, 2026 18:17
Copy link
Member

@brendt brendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts I'd like some input on

@iamdadmin iamdadmin closed this Feb 16, 2026
@iamdadmin iamdadmin force-pushed the 3.x-x-icon-default-sizing branch from 944cddf to 744b7f9 Compare February 16, 2026 14:09
@iamdadmin iamdadmin reopened this Feb 16, 2026
@iamdadmin
Copy link
Contributor Author

Since there was a pile of regression commits due to some formatting errors, I rebased, and re-applied the changes to make this a cleaner commit.

Ready for review again, thanks for the feedback!

@brendt
Copy link
Member

brendt commented Mar 9, 2026

Can you rebase and resolve the conflicts? Then it's good to merge :)

@iamdadmin
Copy link
Contributor Author

Awesome, rebased and conflicts resolved :)

@github-actions
Copy link

Benchmark Results

Comparison of 3.x-x-icon-default-sizing against 3.x (20298c112d5a96149e7523268b882df454d2e4f6).

Open to see the benchmark results
Benchmark Set Mem. Peak Time Variability
ViewRenderBench(benchExpressions) - 23.973mb 0.00% 544.313μs -6.27% ±2.58% +35.92%

Generated by phpbench against commit 2f49c5c

@brendt brendt merged commit b298f25 into tempestphp:3.x Mar 10, 2026
74 checks passed
@brendt
Copy link
Member

brendt commented Mar 10, 2026

Thank you!

@iamdadmin iamdadmin deleted the 3.x-x-icon-default-sizing branch March 10, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View component x-icon defaults to 1em x 1em and doesn't include method to override this

2 participants