feat: add postgresql:// scheme as alias for asyncpg#2154
Open
r266-tech wants to merge 1 commit intotortoise:developfrom
Open
feat: add postgresql:// scheme as alias for asyncpg#2154r266-tech wants to merge 1 commit intotortoise:developfrom
r266-tech wants to merge 1 commit intotortoise:developfrom
Conversation
The official PostgreSQL documentation lists both postgres:// and postgresql:// as valid connection URIs. Previously only postgres:// worked; this adds postgresql:// as a supported scheme alias. Fixes tortoise#2147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
postgresql://as a supported database URL scheme, aliasing to the asyncpg backend — matching the behavior ofpostgres://.The official PostgreSQL documentation lists both
postgres://andpostgresql://as valid connection URIs, and pydantic's PostgresDsn already accepts both. Previously onlypostgres://worked in Tortoise ORM.Changes
tortoise/backends/base/config_generator.py: Addedpostgresqltourlparse.uses_netloc,DB_LOOKUPaliases, and the password-null checktests/backends/test_db_url.py: Addedpostgresqlto_postgres_scheme_enginesdict so all existing postgres scheme tests run against itRelated Issue
Fixes #2147