Fix: Return cycle path as array instead of object map in detectUndirectedCycle#2100
Open
lqaolqao wants to merge 1 commit intotrekhleb:masterfrom
Open
Fix: Return cycle path as array instead of object map in detectUndirectedCycle#2100lqaolqao wants to merge 1 commit intotrekhleb:masterfrom
lqaolqao wants to merge 1 commit intotrekhleb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #2057 by modifying detectUndirectedCycle.js to return a proper ordered array of vertices forming the cycle instead of an object mapping. The change makes the function return a standard path array which is more intuitive and useful for consumers expecting an ordered path of vertices forming the cycle.