-
Notifications
You must be signed in to change notification settings - Fork 40
feat: add foreign build support #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
09dfd45
feat: add foreignBuild case to TargetDependency
fortmarek b975413
feat: redesign foreign build model with ForeignBuildInfo, ForeignBuil…
fortmarek c7addb9
refactor: rename ForeignBuildInfo to ForeignBuild and nest Input/Arti…
fortmarek 673eed7
refactor: simplify ForeignBuild.Artifact to xcframework-only
fortmarek 7c8db3f
fix: remove stale foreignBuild references from TargetDependencyTests
fortmarek a3ef93c
fix: resolve SwiftFormat lint violations across codebase
fortmarek 9980e29
fix: avoid nested #require macro to fix recursive expansion on Linux
fortmarek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import Path | ||
|
|
||
| public struct ForeignBuild: Equatable, Hashable, Codable, Sendable { | ||
| public let script: String | ||
| public let inputs: [Input] | ||
| public let output: Artifact | ||
|
|
||
| public init( | ||
| script: String, | ||
| inputs: [Input], | ||
| output: Artifact | ||
| ) { | ||
| self.script = script | ||
| self.inputs = inputs | ||
| self.output = output | ||
| } | ||
| } | ||
|
|
||
| extension ForeignBuild { | ||
| public enum Input: Equatable, Hashable, Codable, Sendable { | ||
| case file(AbsolutePath) | ||
| case folder(AbsolutePath) | ||
| case script(String) | ||
| } | ||
| } | ||
|
|
||
| extension ForeignBuild { | ||
| public enum Artifact: Equatable, Hashable, Codable, Sendable { | ||
| case xcframework(path: AbsolutePath, linking: BinaryLinking) | ||
|
|
||
| public var path: AbsolutePath { | ||
| switch self { | ||
| case let .xcframework(path, _): return path | ||
| } | ||
| } | ||
|
|
||
| public var linking: BinaryLinking { | ||
| switch self { | ||
| case let .xcframework(_, linking): return linking | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the output of a foreign-built one of the existing types? (i.e.
.xcframework,.library, or.library). If so, but we need to know it's from a foreignBuildOutput, can't we adjust the existing cases?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as here: tuist/tuist#9400 (comment)
For the foreign build, we don't know everything about the
.xcframeworkin advance.