Conversation
Removed callouts
elegaanz
left a comment
There was a problem hiding this comment.
Small things regarding the various logos that I didn't notice in the previous review. It would be nice if you could change that before publishing this new version :)
| // Name of the university | ||
| university: "Università degli Studi di Milano", | ||
| // Path of the logo of the university | ||
| unilogo: "img/unimi.svg", |
There was a problem hiding this comment.
For info this doesn't allow users to import their own logo, only to use the ones shipped with the package (and they have to know the exact name of the file). See this section of the docs for more info. It doesn't have to be fixed in this version if you just want to ship this patch now, but I wanted to let you know for a future version.
There was a problem hiding this comment.
Regarding all these logos, it would be nice to specify under which terms they are distributed and can be used. This is usually done at the end of the package README, but can also go in the LICENSE file or some other dedicated file. If the University doesn't allow for their distribution by third parties, they should be replaced with placeholders and instructions to download them.
There was a problem hiding this comment.
Could it be there isn't a specific license, at all? Should I just write "Unlicensed", in that case?
There was a problem hiding this comment.
This file seems to be duplicated in the parent folder, and also exists in SVG. Is there a reason for that? If not, would it be possible to remove two of them only keep one version please?
I am submitting
Updated
link()to account for Typst 0.14 changes for empty links.