Skip to content

Comments

simple-unimi-thesis:0.1.1#4141

Open
VictuarVi wants to merge 3 commits intotypst:mainfrom
VictuarVi:simple-unimi-thesis-0.1.1
Open

simple-unimi-thesis:0.1.1#4141
VictuarVi wants to merge 3 commits intotypst:mainfrom
VictuarVi:simple-unimi-thesis-0.1.1

Conversation

@VictuarVi
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

Updated link() to account for Typst 0.14 changes for empty links.

  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the update A package update. label Feb 18, 2026
Removed callouts
@elegaanz elegaanz self-assigned this Feb 18, 2026
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things regarding the various logos that I didn't notice in the previous review. It would be nice if you could change that before publishing this new version :)

// Name of the university
university: "Università degli Studi di Milano",
// Path of the logo of the university
unilogo: "img/unimi.svg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For info this doesn't allow users to import their own logo, only to use the ones shipped with the package (and they have to know the exact name of the file). See this section of the docs for more info. It doesn't have to be fixed in this version if you just want to ship this patch now, but I wanted to let you know for a future version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be resolved in c5f2eb1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding all these logos, it would be nice to specify under which terms they are distributed and can be used. This is usually done at the end of the package README, but can also go in the LICENSE file or some other dedicated file. If the University doesn't allow for their distribution by third parties, they should be replaced with placeholders and instructions to download them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be there isn't a specific license, at all? Should I just write "Unlicensed", in that case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be duplicated in the parent folder, and also exists in SVG. Is there a reason for that? If not, would it be possible to remove two of them only keep one version please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be resolved in c5f2eb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update A package update.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants