Skip to content

Comments

Move models under process/models#4101

Merged
je-cook merged 42 commits intomainfrom
models-subdirectory
Feb 19, 2026
Merged

Move models under process/models#4101
je-cook merged 42 commits intomainfrom
models-subdirectory

Conversation

@timothy-nunn
Copy link
Collaborator

No description provided.

@timothy-nunn timothy-nunn requested a review from a team as a code owner February 19, 2026 15:16
@timothy-nunn timothy-nunn marked this pull request as draft February 19, 2026 15:16
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.86%. Comparing base (2812d00) to head (071da26).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4101   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files         136      136           
  Lines       29228    29228           
=======================================
  Hits        13698    13698           
  Misses      15530    15530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn marked this pull request as ready for review February 19, 2026 15:45
Copy link
Collaborator

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment as you're going through this. It might be a good opportunity to shorten some of the filenames eg physics_functions -> physics/functions and resistive_tf_coil -> tfcoil/resistive. Thoughts?

@timothy-nunn
Copy link
Collaborator Author

timothy-nunn commented Feb 19, 2026

One comment as you're going through this. It might be a good opportunity to shorten some of the filenames eg physics_functions -> physics/functions and resistive_tf_coil -> tfcoil/resistive. Thoughts?

functions is not very descriptive, although nor is physics_functions to be fair (Chris thinks it will be gone soon enough, thankfully). Physics functions only contains routines for the radiation power, so I have renamed it as such.

I agree about the resistive however and will do this

@je-cook je-cook merged commit bb358d5 into main Feb 19, 2026
10 checks passed
@je-cook je-cook deleted the models-subdirectory branch February 19, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants