Add remark-breaks so Streamdown matches documented line breaks#382
Open
xhuajin wants to merge 2 commits intovercel:mainfrom
Open
Add remark-breaks so Streamdown matches documented line breaks#382xhuajin wants to merge 2 commits intovercel:mainfrom
xhuajin wants to merge 2 commits intovercel:mainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add remark-breaks to the default remark plugin set so single line breaks render as
<br>per the docs.The documentation mentions that GFM preserves line breaks, but my tests show GFM does not retain line breaks. Line breaks in Streamdown are also merged into a single line. I added remark-breaks to preserve line breaks.
https://streamdown.ai/docs/gfm#line-breaks
https://github.com/remarkjs/remark-breaks
Type of Change
Changes Made
Add remark-breaks to the default remark plugin set so single line breaks render as
<br>per the docs.Testing
Test Coverage
Screenshots/Demos
remark-gfm dosen't preserves the breaks.
Checklist
pnpm changeset)Changeset
Additional Notes