fix: ensure initial matching when -input= option is provided#46
Closed
lambdalisue wants to merge 1 commit intomainfrom
Closed
fix: ensure initial matching when -input= option is provided#46lambdalisue wants to merge 1 commit intomainfrom
lambdalisue wants to merge 1 commit intomainfrom
Conversation
The previous implementation set initialQuery to #previousQuery, which prevented the first matching from executing when an initial query was provided via the -input= option. This fix ensures the first matching always runs by keeping #previousQuery undefined on initialization.
Member
Author
|
Closing in favor of a new PR created from main branch to avoid potential CI issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-input=optioninitialQuerywas being set to#previousQuery, which prevented the matching logic from detecting a query changeChanges
#previousQuerytoundefinedon initialization instead ofinitialQuery-input=option to work correctlyTest plan
-input=option triggers initial matching-input=still works as expected