[RFC] lib: don't allow xbps self-update to bypass integrity checks#597
Open
oreo639 wants to merge 3 commits intovoid-linux:masterfrom
Open
[RFC] lib: don't allow xbps self-update to bypass integrity checks#597oreo639 wants to merge 3 commits intovoid-linux:masterfrom
oreo639 wants to merge 3 commits intovoid-linux:masterfrom
Conversation
oreo639
force-pushed
the
autoup
branch
2 times, most recently
from
9a64ac5 to
9db54ec
Compare
oreo639
force-pushed
the
autoup
branch
3 times, most recently
from
f6aa01e to
3c80f06
Compare
Member
Author
|
I made an alternative version where the self-update check is kept, but just made into a warning if that is preferable? |
Member
|
Seems reasonable to make it a warning. |
When fmt is NULL, xscd.desc never ends up getting set resulting in it containing whatever was previously in memory. Ensure it gets properly set regardless.
oreo639
force-pushed
the
autoup
branch
4 times, most recently
from
7b6aa6f to
c137cf0
Compare
This partially reverts 83ade39. In the past, self-updates mandated that only xbps and its dependencies can be updated if an xbps update is avaliable. As updating dependencies may break their depndents, xbps used XBPS_FLAG_FORCE_REMOVE_REVDEPS in order to bypass integrety checks when using xbps-install -u xbps. This can result in circumstances where the the system is rendered inoperable due to missing or mismatched dependencies of core system packages (e.g. PAM). Downgrade it to a warning, don't bypass integrity checks, and allow full system upgrades to upgrade xbps to ensure that users don't end up with a broken system after upgrading xbps.
Integrity checks are no longer bypassed when updating xbps, and the error has been downgraded to a warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @Duncaen
Right now, this is just a dumb implementation of the fix to get feedback,
this does not currently remove thexbps_autoupdate()mechanism.Ofc if you prefer to go a different route (e.g. static linking) please let me know.
You can test this using libhelloworld and test1 from #580 and then having xbps depends on
libhelloworld>=<helloworld_version>where helloworld_version would be 1 for the first build and 2 for the second ofc.Closes: #592