Open
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
vortex-file/src/filesystem/mod.rs
Outdated
Contributor
|
@claude review |
Contributor
|
Claude finished @0ax1's task in 2m 24s —— View job PR Review: DuckDB Lifetimes
SummaryThis is a well-motivated and cleanly executed refactor that replaces the old 🐛 Bugs1.
pub fn as_slice_with_len<T>(&self, length: usize) -> &[T] {
let ptr = unsafe { cpp::duckdb_vector_get_data(self.as_ptr()) };
unsafe { std::slice::from_raw_parts_mut(ptr.cast::<T>(), length) }
}This method:
Compare with the correctly- 2.
/// Note the lifetime of logical type is tied to &self
pub fn logical_type(&self) -> &LogicalType {
unsafe { LogicalType::borrow(cpp::duckdb_get_value_type(self.as_ptr())) }
}The
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
| /// The caller must ensure that the underlying `ObjectCache` outlives all uses of the | ||
| /// returned reference. In practice, the `ObjectCache` is owned by the `DatabaseInstance` | ||
| /// and lives as long as the database, so this is safe as long as the database is kept alive. | ||
| pub unsafe fn erase_lifetime(&self) -> &'static Self { |
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a little (big) help from Claude, this moves all DuckDB wrapper types to an OwnedFoo / &Foo model and removes the janky
owned: boolfield.