Feat: add chobitsu (Chrome Devtools) for preview#201
Feat: add chobitsu (Chrome Devtools) for preview#201tachibana-shin wants to merge 19 commits intovuejs:mainfrom
chobitsu (Chrome Devtools) for preview#201Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yyx990803
left a comment
There was a problem hiding this comment.
This seems to load the entire devtools frontend which is pretty heavy. I think at the very least it should be added as an opt-in feature that doesn't affect the bundle size of the current base use case (embedding).
src/output/devtools.html
Outdated
| <meta name="referrer" content="no-referrer" /> | ||
| <script | ||
| type="module" | ||
| src="https://cdn.jsdelivr.net/npm/chii/public/front_end/entrypoints/chii_app/chii_app.js" |
There was a problem hiding this comment.
This would make this feature require a network connection.
Currently the repl doesn't use CDN unless the user is selecting a published version of Vue. If a feature requires internet connection then it should be made opt-in.
There was a problem hiding this comment.
I added a chii option in Repl to replace origin when deploying to load chii resources. A small plugin for vite has also been added to load the value for chii
import VitePluginChii from '@vue/repl/plugin-chii'import chii from 'virtual:chii'
function App() {
return <Repl chii={chii} ... />
}
Should I add a separate |
06a2e36 to
41d770d
Compare

Resolves: #197