Provide options allowing users to specify custom grpc SSL credentials#1946
Merged
Provide options allowing users to specify custom grpc SSL credentials#1946
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
dirkkul
reviewed
Feb 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
+ Coverage 86.41% 86.43% +0.02%
==========================================
Files 275 276 +1
Lines 20007 20077 +70
==========================================
+ Hits 17289 17354 +65
- Misses 2718 2723 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dirkkul
reviewed
Feb 18, 2026
| model_config = ConfigDict(arbitrary_types_allowed=True) | ||
|
|
||
| channel_options: Optional[ChannelArgumentType] = Field(default=None) | ||
| credentials: Optional[ChannelCredentials] = Field(default=None) |
Collaborator
There was a problem hiding this comment.
could we add a footgun-check that makes sure that ssl is not deactivated when this is checked?
Collaborator
Author
There was a problem hiding this comment.
Have added a test for this in integration/test_auth.py
…ient into feat/allow-custom-grpc-ssl-creds
dirkkul
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1904