Add option for debug output to default to silent #356
+47
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padelsbach
reviewed
Jan 30, 2026
Contributor
|
Why do we need a special build for this? Why can't they use the env vars? |
padelsbach
reviewed
Feb 2, 2026
| echo " Note: Requires --replace-default. Only for test builds, not for production." | ||
| echo " --leave-silent Enable leave silent mode to suppress logging of return 0 in probing functions where expected failures may occur." | ||
| echo " Note: This only affects logging; the calling function is still responsible for handling all return values appropriately." | ||
| echo " --debug-silent Debug logging compiled in but silent by default. Use WOLFPROV_LOG_LEVEL and WOLFPROV_LOG_COMPONENTS env vars to enable at runtime. Requires --debug." |
Contributor
There was a problem hiding this comment.
Could use --enable-debug-silent for consistency. Or even --enable-debug=silent to simplify the options
padelsbach
approved these changes
Feb 2, 2026
Contributor
Author
For systems with default replace, its difficult to guarantee every running process gets the env vars needed to restrict the output. |
…d-debug-silent-option
padelsbach
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the debug build is noisy with default logging options. This is not suitable for testing systems with many applications as the log pollution becomes a problem. Add option for debug output to default to silent, with option to enable level or component specific logging at runtime with environment variables.