Testing new iron-session package version#1156
Conversation
|
@stanleyphu this would really unblock the cloudflare worker community |
|
Been testing it for a couple of weeks now in a real application and no issues. Real fix should be different, but would help the many-many folks using workers 🙏🏼 Also pinging @mattgd @gcarvelli JIC? |
|
Thanks for the PR @fforres! Problem at the moment is that we need to support Node v16, which iron-session v8 does not if memory serves. We try to circumvent this by providing a worker specific entry point, but clearly something isn't working as expected. |
|
Gentle ping |
|
Hey there! We're actively working on this in a new, |
Description
Related to #1130
Passes all tests, however finding errors on building the final package (using current projects typescript version). As iron-session built package specifies one of their types to be a generic.
I did manually remove the offending type from the created file, built/packaged/released on my account: https://www.npmjs.com/package/@fforres/workos-inc-node and from my tests on a monorepo, seems to be working.
If this helps moving
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.