Conversation
InfoX1337
left a comment
InfoX1337
left a comment
There was a problem hiding this comment.
Two changes needed, change name of the user to avoid confusion and one attached comments for additional tests.
There was a problem hiding this comment.
Add tests to ensure that:
a team member who lacks the REGISTER_TASK permission flag is blocked from registering the team.
a team member who was never part of the team cannot DELETE the team.
Here is a reproduction of a strange behaviour. I accomplished my goal by building empty guard, but in theory it is nullable, however if it actually is null, it throws errors :c |
IMO. We should make it not nullable, and build the guard in the model file with @beforeCreate, but this is a separate issue |
InfoX1337
left a comment
InfoX1337
left a comment
There was a problem hiding this comment.
One comment, apart from that LGTM.
| const response = await client.post('/auth/register').json({ | ||
| nickname: 'user2', | ||
| email: 'user2@local.host', | ||
| nickname: 'n32user', |
There was a problem hiding this comment.
why is this nickname n32user? Could this be changed to newuser?
2 participants
During development of this PR, I observed weird situation, because I got errors during migrations when I tried to create team member without any permissions! It should be looked into🤨
//PS: pls review