Force conversion unit in format_size#47
Open
sebastian-luna-valero wants to merge 9 commits intoxolox:masterfrom
Open
Force conversion unit in format_size#47sebastian-luna-valero wants to merge 9 commits intoxolox:masterfrom
sebastian-luna-valero wants to merge 9 commits intoxolox:masterfrom
Conversation
Author
|
Hi @xolox All tests are passing except for Please have a look and let me know your thoughts. Many thanks, |
Author
|
Hi again, Alright so adding tests for the new code solves the Please have a look and let me know your thoughts. Best regards, |
|
any news on this? |
Author
|
Hi, Probably my changes are a bit too much for this package and that's why it hasn't been merge. I have just taken the relevant code out and copied it to my own script. @yodog I recommend you to do the same. If you think it is interesting, I might upload it to my own git repo and share it with you. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We are interested in adding an optional flag to
format_size()so you can force the conversion unit.Here is the desired behaviour:
Best regards,
Sebastian