Open
Conversation
…itonradiativelifetimes.py
…f multiple runs to extract response new file: yambopy/nl/sin_analysis.py => class for analysis of multiple runs with monochromatic signal to extract response
modified: yambopy/nl/freqmix_analysis.py modified: yambopy/nl/nl_analysis.py modified: yambopy/nl/pulse_analysis.py modified: yambopy/nl/sin_analysis.py Moved get_sampling as common method in nl_analysis.py and created the abstract method set_sampling to get the specific range/sampling number
extra code deleted
Upadated documentation to be consistent with changes introduced in the code
Bug fixes in excitonradiativelifetimes.py
attacc
reviewed
Mar 6, 2026
Contributor
attacc
left a comment
attacc
left a comment
There was a problem hiding this comment.
Branch tested and perfectly working.
It also fixes a but in the sum-frequency extrapolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I create the$P$ and current $J$ .
Xn_from_signalabstract python class and a set of derived classes for extracting nonlinear susceptibilities and conductivities from the macroscopic time-dependent polarizationThis is the start for rationalizing the nl part which has grown following need. Code which initiallly was translated from fortran ypp, was copied to a new file and modified to add new functionalities since the structure was very similar. This change is an attempt to highlight/force that structure even though keeping a file for each functionality.
Documentation is drafted in in Xn_from_signal_doc.md