fix(service): auto-resolve environmentID in network and port-forward#187
Merged
fix(service): auto-resolve environmentID in network and port-forward#187
Conversation
…commands Both commands required --env-id flag in non-interactive mode, but every project has exactly one environment. Use ResolveEnvironmentIDByServiceID to auto-resolve when --env-id is not provided. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review WalkthroughBoth the network and port-forward service command files now auto-resolve the environmentID from the serviceID when environmentID is not provided, instead of treating it as a missing required parameter. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service networkandservice port-forwardboth required--env-idin non-interactive modeutil.ResolveEnvironmentIDByServiceIDthat other commands already use (expose, restart, etc.)Before
After
🤖 Generated with Claude Code
Summary by CodeRabbit