Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 2 | Form-Controls#1177
Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 2 | Form-Controls#1177Alaterry8 wants to merge 8 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Alaterry8
added
the
Needs Review
|
|
||
| </P> | ||
|
|
||
|
|
There was a problem hiding this comment.
How do we submit the result of the form to the server? Do we need a special control for it?
|
|
||
| <br> <br> | ||
| <label for="colour"> T-shirt colour:</label> | ||
| <select id="colour" name="T-shirt colour"> |
There was a problem hiding this comment.
Note, we must require the user to actively select colour. Therefore initial option should be empty and we must demand the choise.
|
|
||
| <br> <br> | ||
| <label for="XS"> XS</label> | ||
| <input type="radio" id="XS" name="Size"> |
There was a problem hiding this comment.
How do we make sure that user selected t-shirt size? Currently I may avoid selecting any.
|
|
||
| <br> <br> | ||
| <label for="S"> S</label> | ||
| <input type="radio" id="S" name="Size"> |
There was a problem hiding this comment.
Have a look into each radio button. Which value will server receive when the appropriate radio button is selected? How will it distinguish one radio button from another?
| </select> | ||
|
|
||
| <br> | ||
| <P> Size: |
There was a problem hiding this comment.
p tag is used typically for paragraph of text. Is there a tag which allows to group controls together? Is there a way to have a legend annotating the control appropriately?
| @@ -1,4 +1,4 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
what was the reason to change from DOCTYPE to doctype?
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <label for="name"> Name: </label> | ||
| <input type="text" id="name" name="Name" minlength="2" required> |
There was a problem hiding this comment.
The convention for naming elements (i.e' name) is lowercase
|
|
||
| <br> <br> | ||
| <label for="colour"> T-shirt colour:</label> | ||
| <select id="colour" name="T-shirt colour"> |
There was a problem hiding this comment.
the convention for name is to avoid usage spaces. Use underscore or dash instead
SlideGauge
added
Reviewed
2 participants
Self checklist
Within a form, I added a name field with minimum 2 characters length requirement. I added an email field. I added a set of 3 colours to select from. I added 6 radio options for Size options.