Skip to content

Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 2 | Form-Controls #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alaterry8 wants to merge 12 commits into
base: main
Choose a base branch
from
+70 −18
Open

Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 2 | Form-Controls #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
11a6944
Add name field and submit button to test validation
Alaterry8 Feb 14, 2026
667fd99
Add email field
Alaterry8 Feb 14, 2026
8caf0c5
Add T-shirt colour field
Alaterry8 Feb 14, 2026
1dd5b4c
Add Size options via radio buttons
Alaterry8 Feb 14, 2026
0f0e9d3
Remove submit button
Alaterry8 Feb 14, 2026
1774cf2
Attach labels to unputs
Alaterry8 Feb 14, 2026
cda92fc
Add spacing between controls
Alaterry8 Feb 14, 2026
20bf3d9
Check requirements
Alaterry8 Feb 14, 2026
d37ee80
Add empty value to colour set and make it required to choose
Alaterry8 Feb 16, 2026
59dd754
Add fieldset for size options and make it required to choose
Alaterry8 Feb 16, 2026
99585ec
fix capitalisation and spacing issues
Alaterry8 Feb 16, 2026
64112a7
Capitalise Doctype
Alaterry8 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Form-Controls/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

<!--{{<objectives>}}>-->

- [ ] Interpret requirements and check against a list of criteria
- [ ] Write a valid form
- [ ] Test with Devtools
- [ ] Refactor using Devtools
- [x] Interpret requirements and check against a list of criteria
- [x] Write a valid form
- [x] Test with Devtools
- [x] Refactor using Devtools
<!--{{<objectives>}}>-->

## Task
Expand All @@ -30,18 +30,18 @@ Do not write a form action for this project.

Let's write out our testable criteria. Check each one off as you complete it.

- [ ] I have used HTML only.
- [x] I have used HTML only.
- [x] I have not used any CSS or JavaScript.

### HTML

- [ ] My form is semantic html.
- [ ] All inputs have associated labels.
- [ ] My Lighthouse Accessibility score is 100.
- [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
- [ ] I require a valid email.
- [ ] I require one colour from a defined set of 3 colours.
- [ ] I require one size from a defined set of 6 sizes.
- [x] My form is semantic html.
- [x] All inputs have associated labels.
- [x] My Lighthouse Accessibility score is 100.
- [x] I require a valid name. I have defined a valid name as a text string of two characters or more.
- [x] I require a valid email.
- [x] I require one colour from a defined set of 3 colours.
- [x] I require one size from a defined set of 6 sizes.

## Resources

Expand Down
64 changes: 58 additions & 6 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,72 @@
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>

<header>
<h1>Product Pick</h1>
</header>

<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<label for="name"> Name: </label>
<input type="text" id="name" name="name" minlength="2" required>

<br> <br>
<label for="email"> Email: </label>
<input type="email" id="email" name="email" required>

<br> <br>
<label for="colour"> T-shirt colour:</label>
<select id="colour" name="t-shirt_colour" required>
<option value=""></option>
<option value="Red"> Red</option>
<option value="Blue"> Blue</option>
<option value="Green"> Green</option>

</select>

<br><br>

<fieldset>

<legend>Size: </legend>


<label for="XS"> XS</label>
<input type="radio" id="XS" name="size" value="XS" required>

<br> <br>
<label for="S"> S</label>
<input type="radio" id="S" name="size" value="S">

<br> <br>
<label for="M"> M</label>
<input type="radio" id="M" name="size" value="M">

<br> <br>
<label for="L"> L</label>
<input type="radio" id="L" name="size" value="L">

<br> <br>
<label for="XL"> XL</label>
<input type="radio" id="XL" name="size" value="XL">

<br> <br>
<label for="XXL"> XXL</label>
<input type="radio" id="XXL" name="size" value="XXL">

</fieldset>

<br>
<button type="submit"> Submit </button>


Copy link

@SlideGauge SlideGauge Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we submit the result of the form to the server? Do we need a special control for it?

Copy link
Author

@Alaterry8 Alaterry8 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed this issue by adding a button at the end. Thank you for pointing that out :D

</form>
</main>

<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>

<h2>Ahmed Elmahmoudi</h2>
</footer>
</body>
</html>