Register CLEM colours #739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 46.65% 46.91% +0.25%
==========================================
Files 91 91
Lines 9607 9665 +58
Branches 1255 1270 +15
==========================================
+ Hits 4482 4534 +52
- Misses 4912 4914 +2
- Partials 213 217 +4 🚀 New features to boost your workflow:
|
tieneupin
force-pushed
the
register-clem-colours
branch
from
f109365 to
095520d
Compare
tieneupin
added
server
d-j-hatton
reviewed
Feb 6, 2026
d-j-hatton
approved these changes
Feb 6, 2026
Contributor
d-j-hatton
left a comment
d-j-hatton
left a comment
There was a problem hiding this comment.
Looks good. Looking cool in PATo so good to progress this
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… the Atlas and GridSquare tables in ISPyB for the CLEM workflow
…ng the 'get' call
…of just activating the ones it receives; fixed colour flag and collection mode insertion logic for the Atlas
…e used for dataset
…rival of message, then translate it across to Atlas and GridSquare tables in ISPyB
tieneupin
force-pushed
the
register-clem-colours
branch
from
d121b9e to
d7320d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently released version of
ispyb-apiincludes new columns in the Atlas and GridSquare tables that can be used to keep track of the data collection mode used for, and the colour channels present in, a particular dataset.This PR adds optional logic to the Atlas and GridSquare insertion/update functions to register the colour channel information and collection mode associated with the CLEM workflow. This involves adding new columns to the
CLEMImageSeriesMurfey database table. Additionally, it fixes an error with how the size of the ROI on the atlas image is calculated.