Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
==========================================
- Coverage 90.83% 90.70% -0.13%
==========================================
Files 22 22
Lines 3009 3031 +22
==========================================
+ Hits 2733 2749 +16
- Misses 276 282 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
afc4ef8 to
58906c7
Compare
This reverts commit 2630f64.
|
The remaining errors likely come from EDIT: I've confirmed that this is indeed the case; when I disable nest_asyncio, the failing tests are passing. (of course different tests start to fail in that case, as expected) |
This reverts commit 8199166.
|
@unkcpz I got Python 3.14 working here 🎉 |
TODO: Write a test for this, it was causing test failures in aiida-core
|
TODO: For me, report bug to uv about installing for git branches for repos with dynamic versions. |
|
I've opened a corresponding aiida-core PR to prove that things here works: It also seems like my fix I think this is ready for initial review. @unkcpz |
The crucial thing to resolve for Python 3.14 is the
asyncio.get_event_loopbehaviour change -- it now raisesRuntimeErrorif there's not event loop running. See #283.This is based on #308 that I rebased on master.
I'll try to make a minimal set of changes required for tests to pass on Python 3.14.