This repository was archived by the owner on Apr 24, 2024. It is now read-only.
OSPF: WIP formatting documentation for ospf#36
Open
agneya2001 wants to merge 2 commits intoapache:masterfrom
Open
OSPF: WIP formatting documentation for ospf#36agneya2001 wants to merge 2 commits intoapache:masterfrom
agneya2001 wants to merge 2 commits intoapache:masterfrom
Conversation
5 tasks
cb02452 to
dca4860
Compare
Member
|
Hi @agneya2001, could you please consider the following suggestions?
Thanks. |
Author
|
@GabrielBrascher all suggestions are good, made them for some i will have to tune the code, will do that too. |
Contributor
|
@agneya2001 , any update on the merge of your code in the upstream ? Regards, |
Member
|
@GabrielBrascher and @pdion891 what are your feedback here? +1 or -1? |
rafaelweingartner
approved these changes
Feb 21, 2018
Contributor
|
@rafaelweingartner, I think it's still a work in progress, I'm not aware this feature got merged into master yet. |
Member
|
You are right. I did not notice that. I checked that PR, and I do not believe that it will get ready any time soon. |
Member
|
The is still pending, we can leave both the doc and code PRs until they are resumed by someone in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: documentation for ospf