[fix][client] Return client close promise #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Fixes the JS client wrapper so that await client.close() actually waits for the underlying native client shutdown, aligning runtime behavior with the declared TypeScript API.
Changes:
- Return the underlying native
this.client.close()promise fromClient.close().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
51
to
53
| close() { | ||
| this.client.close(); | ||
| return this.client.close(); | ||
| } |
There was a problem hiding this comment.
Consider adding a Jest test that asserts client.close() returns a Promise (and can be awaited). The existing tests await client.close() would still pass when close() returned undefined, so they wouldn't catch a regression of this bug fix.
BewareMyPower
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456
Motivation
Awaiting
client.close()will not properly wait for the client to close before continuing.Modifications
Return the promise in the
closemethod.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededFixes existing interaction
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)