Skip to content

[fix][client] Return client close promise #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BewareMyPower merged 1 commit into from
Feb 11, 2026
Merged

[fix][client] Return client close promise #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class Client {
}

close() {
this.client.close();
return this.client.close();
}
Comment on lines 51 to 53
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a Jest test that asserts client.close() returns a Promise (and can be awaited). The existing tests await client.close() would still pass when close() returned undefined, so they wouldn't catch a regression of this bug fix.

Copilot uses AI. Check for mistakes.

static setLogHandler(params) {
Expand Down
Loading