Merged
Conversation
Signed-off-by: Matej Ohradzansky <[email protected]>
Signed-off-by: Matej Ohradzansky <[email protected]>
1 task
iciclespider
approved these changes
Nov 21, 2025
Collaborator
|
@P0t4T0o If you can resolve the lint error, I'll get a new version of this released with it. |
Signed-off-by: Matej Ohradzansky <[email protected]>
Contributor
Author
|
Hi @iciclespider, |
ezgidemirel
reviewed
Nov 24, 2025
crossplane/function/runtime.py
Outdated
| address: The address at which to listen for requests. | ||
| creds: The credentials used to authenticate requests. | ||
| insecure: Serve insecurely, without credentials or encryption. | ||
| options: Additional gRPC server options. |
Member
There was a problem hiding this comment.
nitpick: we can give some option examples
ezgidemirel
approved these changes
Nov 24, 2025
Member
ezgidemirel
left a comment
ezgidemirel
left a comment
There was a problem hiding this comment.
Thanks for the PR @P0t4T0o, LGTM!
Signed-off-by: Matej Ohradzansky <[email protected]>
iciclespider
approved these changes
Nov 24, 2025
negz
reviewed
Nov 24, 2025
Comment on lines
+20
to
+21
| from collections.abc import Sequence | ||
| from typing import Any |
Member
There was a problem hiding this comment.
We typically try to avoid importing types directly, but instead only import packages. I thought our linter should catch this. I'll update it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #187
I have:
[ ] Added or updated unit tests for my change.