Enable devcontainer in Workflows by MaximilianSoerenPollak · Pull Request #411 · eclipse-score/docs-as-code

MaximilianSoerenPollak · 2026-02-23T16:03:41Z

Benefits:

yamlfmt, ruff, basedpyright, actionlint, shellcheck, buildifier versions dictated centrally by devcontainer
centralized "open in devcontainer and you are good to go", no custom commands like install bazel and run ide_support
same baseline for debugging. An issue is reported and you can get to the same baseline 'faster' than before

Drawbacks:

increase in startup time of dev environment
increase in CI runtime
pre-commit will not work without devcontainer

github-actions · 2026-02-23T16:04:35Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 15544b84-06b3-49a6-838b-abff74b58e9c
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (66 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (69 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (76 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (128 packages loaded, 1673 targets configured)

Analyzing: target //src:license-check (135 packages loaded, 2527 targets configured)

Analyzing: target //src:license-check (135 packages loaded, 2527 targets configured)

Analyzing: target //src:license-check (135 packages loaded, 2527 targets configured)

Analyzing: target //src:license-check (136 packages loaded, 2527 targets configured)

Analyzing: target //src:license-check (139 packages loaded, 4537 targets configured)

Analyzing: target //src:license-check (144 packages loaded, 4589 targets configured)

INFO: Analyzed target //src:license-check (145 packages loaded, 4715 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 23.314s, Critical Path: 2.48s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-02-23T16:09:16Z

The created documentation from the pull request is available at: docu-html

lurtz · 2026-02-24T11:33:32Z

.devcontainer/devcontainer.json

 {
    "name": "eclipse-s-core",
-    "image": "ghcr.io/eclipse-score/devcontainer:1.0.0",
+    "image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",


Can you add this and tell me if you stell need PIPX_BIN_DIR to execute pre-commit?

Suggested change

"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",

"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",

"postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" | sudo tee /etc/bash_completion.d/add_pipx_to_path",

This only works in conjunction with devcontainer/cli. If this works I can add this to the image.

Now I found a solution, which works in /etc/profile.d/. This took me way too long time

Suggested change

"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",

"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",

"postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" | sudo tee /etc/profile.d/add_pipx_to_path.sh",

Will be taken care of with eclipse-score/devcontainer#98

.pre-commit-config.yaml

MaximilianSoerenPollak · 2026-02-25T09:12:24Z

Converted to Draft, as currently unsure if this PR is in the right direction of the Repo.

AlexanderLanin · 2026-02-25T11:08:07Z

@MaximilianSoerenPollak have fun merging/rebasing. Looks like there are some conflicts.

lurtz · 2026-02-25T11:36:50Z

.github/workflows/lint.yml

-        run: bash scripts/run-linters.sh
+          cacheFrom: ghcr.io/eclipse-score/devcontainer
+          push: never
+          runCmd: ${PIPX_BIN_DIR}/pre-commit run -a


With the current main tag PIPX_BIN_DIR is now part of $PATH

Suggested change

runCmd: ${PIPX_BIN_DIR}/pre-commit run -a

runCmd: pre-commit run -a

lurtz · 2026-02-25T11:37:56Z

.github/workflows/test.yml

-      - name: Setup Bazel with cache
-        uses: bazel-contrib/[email protected]


We should keep an eye on build times and if we can use a cache with the devcontainer

lurtz · 2026-02-25T11:41:24Z

.github/workflows/consumer_test.yml

+            export PYTHONUNBUFFERED="1"
+            export CONSUMER="${{ matrix.consumer }}"
+            export PYTHONPATH=.
+            uv run pytest -s -v src/tests/ \


pytest is preinstalled in the devcontainer and should be accessible without uv. Maybe uv just runs what is already there

Yes pytest is there, but the packages this test needs arent'.

So i installe eveyrthing via uv then running it

MaximilianSoerenPollak · 2026-02-25T15:38:56Z

I honestly do not know why some of the changes it says they are new here ?

github-project-automation bot added this to INF - Infrastructure Community Feb 23, 2026

github-project-automation bot moved this to Draft in INF - Infrastructure Community Feb 23, 2026

MaximilianSoerenPollak force-pushed the MSP_add_pre_commit branch from e355b24 to 8e28246 Compare February 24, 2026 10:10

lurtz reviewed Feb 24, 2026

View reviewed changes

MaximilianSoerenPollak marked this pull request as ready for review February 25, 2026 07:14

MaximilianSoerenPollak requested review from AlexanderLanin, dcalavrezo-qorix and nradakovic as code owners February 25, 2026 07:14

AlexanderLanin reviewed Feb 25, 2026

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

MaximilianSoerenPollak marked this pull request as draft February 25, 2026 09:12

lurtz reviewed Feb 25, 2026

View reviewed changes

MaximilianSoerenPollak force-pushed the MSP_add_pre_commit branch from 9492a27 to 92f9c8b Compare February 25, 2026 14:07

MaximilianSoerenPollak marked this pull request as ready for review February 25, 2026 14:51

MaximilianSoerenPollak changed the title ~~Add pre-commit config & upgrade devcontainer~~ Enable devcontainer in Workflows Feb 25, 2026

MaximilianSoerenPollak force-pushed the MSP_add_pre_commit branch from b64929d to 4d840de Compare February 25, 2026 15:50

AlexanderLanin mentioned this pull request Feb 25, 2026

various fixes #420

Merged

Enabeling devcontainer

a19c097

MaximilianSoerenPollak force-pushed the MSP_add_pre_commit branch from 4d840de to a19c097 Compare February 25, 2026 18:16

	"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
	"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
	"postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" \| sudo tee /etc/bash_completion.d/add_pipx_to_path",

	runCmd: ${PIPX_BIN_DIR}/pre-commit run -a
	runCmd: pre-commit run -a

		- name: Setup Bazel with cache
		uses: bazel-contrib/[email protected]

Conversation

MaximilianSoerenPollak commented Feb 23, 2026 • edited by AlexanderLanin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MaximilianSoerenPollak commented Feb 25, 2026

Uh oh!

AlexanderLanin commented Feb 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MaximilianSoerenPollak commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MaximilianSoerenPollak commented Feb 23, 2026 •

edited by AlexanderLanin

Loading

github-actions bot commented Feb 23, 2026 •

edited

Loading