Add import-side array handling and JSClass array tests #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/18e3-bridgejs-import
branch
3 times, most recently
from
731032d to
c1b87ad
Compare
…SCore/ImportTS.swift` to allow array lowering/lifting (stack-based, no ABI params) and to handle stack-only parameters in `CallJSEmission`. `Plugins/BridgeJS/Sources/BridgeJSLink/JSGlueGen.swift` now lifts array parameters and lowers array returns for imported JS functions using existing array fragments. `Sources/JavaScriptKit/BridgeJSIntrinsics.swift` gives `Array` stack bridging conformance plus import helpers (`bridgeJSLowerParameter`, `bridgeJSLiftReturn`, `bridgeJSLowerStackReturn`), covering nested arrays. Added `Plugins/BridgeJS/Tests/BridgeJSToolTests/Inputs/MacroSwift/ImportArray.swift` with corresponding snapshots for JSFunction array imports. Tests: `UPDATE_SNAPSHOTS=1 swift test --package-path ./Plugins/BridgeJS --filter BridgeJSCodegenTests` followed by `swift test --package-path ./Plugins/BridgeJS --filter BridgeJSCodegenTests` (pass). Next steps: 1) Run the full BridgeJS test suite (`swift test --package-path ./Plugins/BridgeJS`) to ensure wider coverage. 2) Consider runtime-side coverage (e.g., `make unittest` with `JAVASCRIPTKIT_EXPERIMENTAL_BRIDGEJS=1`) if you want to exercise the new import path end-to-end.
kateinoigakukun
force-pushed
the
katei/18e3-bridgejs-import
branch
from
c1b87ad to
858bac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Overview: