Skip to content

Conversation

@gjtorikian
Copy link
Contributor

Summary

  • Set include-component-in-tag: false in release-please-config.json so future tags are v6.1.0 instead of workos/v6.1.0
  • Update VERSION extraction in release.yml to handle both tag formats as a safety net

Context

The v6.1.0 release (publish run) failed because:

  1. Release Please created a tag workos/v6.1.0 (component-prefixed)
  2. The publish workflow derived VERSION via ${GITHUB_REF_NAME#v}workos/v6.1.0 (no leading v to strip)
  3. gem push looked for pkg/workos-workos/v6.1.0.gem which doesn't exist

Test plan

🤖 Generated with Claude Code

Release Please was creating tags like `workos/v6.1.0` instead of
`v6.1.0` because `include-component-in-tag` defaults to true. This
caused the publish workflow to look for `pkg/workos-workos/v6.1.0.gem`
instead of `pkg/workos-6.1.0.gem`.

- Set `include-component-in-tag: false` in release-please-config.json
- Update VERSION extraction in release.yml to handle both tag formats

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gjtorikian gjtorikian requested a review from a team as a code owner February 10, 2026 19:23
@gjtorikian gjtorikian requested review from nicknisi and removed request for a team February 10, 2026 19:23
@gjtorikian gjtorikian closed this Feb 10, 2026
@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR attempts to fix the v6.1.0 release failure by configuring release-please to generate simple v6.1.0 tags instead of workos/v6.1.0, and updates the VERSION extraction logic to handle both formats.

Key changes:

  • Adds include-component-in-tag: false to release-please-config.json (correct)
  • Updates VERSION extraction from ${GITHUB_REF_NAME#v} to ${GITHUB_REF_NAME##*/v} (buggy)

Critical issue found:
The new bash pattern ##*/v removes everything up to and including /v, but doesn't handle simple tags correctly:

  • For workos/v6.1.0 → extracts 6.1.0
  • For v6.1.0 → extracts v6.1.0 ✗ (leaves the v prefix)

This will cause the next release to fail because gem push will look for pkg/workos-v6.1.0.gem instead of pkg/workos-6.1.0.gem.

Confidence Score: 0/5

  • This PR contains a critical bug that will cause the publish workflow to fail
  • The VERSION extraction logic has a bug that will leave the v prefix on simple tags, causing gem push to look for the wrong filename and fail
  • .github/workflows/release.yml requires immediate attention - the VERSION extraction pattern is incorrect

Important Files Changed

Filename Overview
.github/workflows/release.yml VERSION extraction logic has a critical bug - won't strip v prefix from simple tags, causing gem push to fail
release-please-config.json Added include-component-in-tag: false to generate simple v* tags instead of workos/v* - looks correct

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

- name: Publish to RubyGems
run: |
VERSION="${GITHUB_REF_NAME#v}"
VERSION="${GITHUB_REF_NAME##*/v}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern ##*/v won't strip the v from simple tags like v6.1.0 - it will output v6.1.0 instead of 6.1.0. This causes gem push to look for pkg/workos-v6.1.0.gem which won't exist.

Suggested change
VERSION="${GITHUB_REF_NAME##*/v}"
VERSION="${GITHUB_REF_NAME##*/}"
VERSION="${VERSION#v}"

@gjtorikian gjtorikian deleted the fix-release-tag-format branch February 10, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant