Skip to content

fix: use simple v-prefixed tags and fix gem publish path #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gjtorikian wants to merge 1 commit into from
+3 −2
Closed

fix: use simple v-prefixed tags and fix gem publish path #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ jobs:

- name: Publish to RubyGems
run: |
VERSION="${GITHUB_REF_NAME#v}"
VERSION="${GITHUB_REF_NAME##*/v}"
Copy link

@greptile-apps greptile-apps bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern ##*/v won't strip the v from simple tags like v6.1.0 - it will output v6.1.0 instead of 6.1.0. This causes gem push to look for pkg/workos-v6.1.0.gem which won't exist.

Suggested change
VERSION="${GITHUB_REF_NAME##*/v}"
VERSION="${GITHUB_REF_NAME##*/}"
VERSION="${VERSION#v}"

bundle exec rake build
gem push pkg/workos-${VERSION}.gem --host https://rubygems.org
3 changes: 2 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"release-type": "ruby",
"package-name": "workos",
"version-file": "lib/workos/version.rb",
"changelog-path": "CHANGELOG.md"
"changelog-path": "CHANGELOG.md",
"include-component-in-tag": false
}
}
}